PCD Viewer - Githubissues

jontromanab / sq_grasp

superquadrics based grasping

11 stars 4 forks source link

PCD Viewer #4

Closed ommmid closed 5 years ago

ommmid commented 5 years ago

Added a node to load any *.pcd file and display it with "pcl::visualization::CloudViewer".

jontromanab commented 5 years ago

The pcd_viewer code can be easily executed by pcl_viewer from point cloud library. However I am going to keep it.
The sq_test_node is unnecessary sampling_test_pcd.cpp
There is a nice documentation of shared, unique and raw pointer. why it is there? (Possibly remove it)
The comments in line 28, 52 and 62 does not make much sense. (Possibly remove them)

ommmid commented 5 years ago

Comments are only for my understanding. And sq_test_node was just a test. All will be removed

jontromanab commented 5 years ago

Ok. remove them. Otherwise they will be merged.

jontromanab commented 5 years ago

ok. I am merging this. It is OK, as it is a small kind-of-testing development. But from the next time, try to create a branch naming the module you are developing and create a PR from there. Best practice and we can keep track of changes.