fixed bug where only default XmlObjectSerializer is being returned ev…

danomite commented 6 years ago

…en though we're setting rules for custom one

Description

DbSerializerRules aren't being respected for Xml column types, if you add a custom serializer, it will just be ignored and the default XmlObjectSerializer keeps being returned instead

Checklist

Please make sure your pull request fulfills the following requirements:

[x] Tests for any changes have been added (for bug fixes / features).
[ ] Docs have been added / updated (for bug fixes / features).

Type

This pull request includes what type of changes?

[x] Bug.
[ ] Feature.
[ ] Code style update (formatting, local variables).
[ ] Refactoring (no functional changes, no api changes).
[ ] Documentation content changes.
[ ] Other (please describe below).

Breaking Changes

Does this pull request introduce any breaking changes?

[ ] Yes
[x] No

Any other comment

My first real PR on github, hopefully it checks out okay! How often are nuget packages published? Really could use this one as a package.

jonwagner commented 6 years ago

It looks like we have a few open issues that we can take care of. I'll shoot for a build early next week. (~8/13/18)

danomite commented 6 years ago

Thanks! Really appreciate the quick turnaround

jonwagner commented 6 years ago

Looks good. This will be in 6.2.4 to be released this week

jonwagner commented 6 years ago

This is merged into in 6.2.4, now available.

jonwagner / Insight.Database