search

jonwagner / Insight.Database

Fast, lightweight .NET micro-ORM
Other
861 stars 145 forks source link

Fixup dynamic datetime #403

Closed rkramer1964 closed 5 years ago

rkramer1964 commented 5 years ago

…meters.

Description

Dynamic (and FastExpando) parameter objects were failing to pass datetime2 values to commands due to missing provider.FixupParameter call, e.g. "1/1/0001 12:00:00am" was causing SqlTypeExceptions.

Checklist

Please make sure your pull request fulfills the following requirements:

Type

This pull request includes what type of changes?

Breaking Changes

Does this pull request introduce any breaking changes?

Any other comment

(n/a)

jonwagner commented 5 years ago

Cool. We can do a build.

On Aug 29, 2019, at 8:09 PM, rkramer1964 notifications@github.com<mailto:notifications@github.com> wrote:

…meters.

Description

Dynamic (and FastExpando) parameter objects were failing to pass datetime2 values to commands due to missing provider.FixupParameter call, e.g. "1/1/0001 12:00:00am" was causing SqlTypeExceptions.

Checklist

Please make sure your pull request fulfills the following requirements:

Type

This pull request includes what type of changes?

Breaking Changes

Does this pull request introduce any breaking changes?

Any other comment

(n/a)

You can view, comment on, or merge this pull request online at:

https://github.com/jonwagner/Insight.Database/pull/403

Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/jonwagner/Insight.Database/pull/403?email_source=notifications&email_token=AAMTO5FGKLLAVKMEHWHYJEDQHBQNJA5CNFSM4ISH5EQ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HIKPZ5Q, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAMTO5FCIMZLSE7XQOBXYWTQHBQNJANCNFSM4ISH5EQQ.

rkramer1964 commented 5 years ago

Thanks.  This is causing us a bit of grief on our project.

Keep me posted, please, on the release progress.

Rick

Quoting Jon Wagner notifications@github.com:

Cool. We can do a build.

On Aug 29, 2019, at 8:09 PM, rkramer1964
notifications@github.com<mailto:notifications@github.com> wrote:

…meters.

Description

Dynamic (and FastExpando) parameter objects were failing to pass
datetime2 values to commands due to missing provider.FixupParameter
call, e.g. "1/1/0001 12:00:00am" was causing SqlTypeExceptions.

Checklist

Please make sure your pull request fulfills the following requirements:

  • [x ] Tests for any changes have been added (for bug fixes / features).
  • Docs have been added / updated (for bug fixes / features).

Type

This pull request includes what type of changes?

  • [X ] Bug.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Documentation content changes.
  • Other (please describe below).

Breaking Changes

Does this pull request introduce any breaking changes?

  • Yes
  • [ X] No

Any other comment

(n/a)

You can view, comment on, or merge this pull request online at:

https://github.com/jonwagner/Insight.Database/pull/403

Commit Summary

  • Add fixupParameter call to fix datetime -> datetime2 for dynamic
    parameters.
  • Updating tests

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on
GitHubhttps://github.com/jonwagner/Insight.Database/pull/403?email_source=notifications&email_token=AAMTO5FGKLLAVKMEHWHYJEDQHBQNJA5CNFSM4ISH5EQ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HIKPZ5Q, or mute the
threadhttps://github.com/notifications/unsubscribe-auth/AAMTO5FCIMZLSE7XQOBXYWTQHBQNJANCNFSM4ISH5EQQ.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub[1], or mute the thread[2].

Links:

[1]
https://github.com/jonwagner/Insight.Database/pull/403?email_source=notifications&email_token=AGNY7XQAS5AAIZ3SRQYYEQTQHBQXFA5CNFSM4ISH5EQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5QFCJA#issuecomment-526405924 [2]
https://github.com/notifications/unsubscribe-auth/AGNY7XSN2QRZQE2EYTWG4FTQHBQXFANCNFSM4ISH5EQQ

jonwagner commented 5 years ago

@rkramer1964 v 6.2.10 is in nuget now.