jonwagner / Insight.Database

Fast, lightweight .NET micro-ORM
Other
857 stars 145 forks source link

Update Oracle image for docker-compose. #444

Closed KevinEdwardBerry closed 4 years ago

KevinEdwardBerry commented 4 years ago

Description

The current listing for an Oracle image in the docker-compose file, namely sath89/oracle-12c, no longer exists. I updated the file to use an existing copy of the current image (first thing that came up in a search on hub.docker.com ). Feel free to change it. I just wanted to make sure others who attempt to use the docker-compose file would not run into the same issue.

Checklist

Please make sure your pull request fulfills the following requirements:

Type

This pull request includes what type of changes?

Breaking Changes

Does this pull request introduce any breaking changes?

Any other comment

As mentioned in the description, this only updates the named docker image in the docker-compose file. If author or maintainers wish to use a different image available, feel free to update this PR with the preferred one.

jonwagner commented 4 years ago

Good catch. I updated to the official oracle version. It requires logging into docker hub and agreeing to terms of service, but it's official.

jonwagner commented 4 years ago

Good catch. I updated to the official oracle version. It requires logging into docker hub and agreeing to terms of service, but