Implement OneToOne.GetHashCode() to fix a memory leak

[ryan-westenhover]

Description

This PR fixes a memory leak that was happening in Insight.Database.CodeGenerator.DbReaderDeserializer caused by GetHashCode not being implemented in the OneToOne mapping class.

There is an existing pre-calculated _hashCode field that looks appropriate for this class, but it was never exposed through the GetHashCode method. This led to an issue where the static ConcurrentDictionary _deserializers in DbReaderDeserializer that is caching the deserializers was not recognizing that a deserializer already exists for a particular reader when checking if it needs to add a new one, ultimately leading to new deserializers accumulating in that cache over time and never getting released.

Checklist

Please make sure your pull request fulfills the following requirements:

• [x] Tests for any changes have been added (for bug fixes / features).
• [x] Docs have been added / updated (for bug fixes / features).

Type

This pull request includes what type of changes?

• [x] Bug.
• [ ] Feature.
• [ ] Code style update (formatting, local variables).
• [ ] Refactoring (no functional changes, no api changes).
• [ ] Documentation content changes.
• [ ] Other (please describe below).

Breaking Changes

Does this pull request introduce any breaking changes?

• [ ] Yes
• [x] No

Any other comment

(n/a)

[jonwagner]

Cool. I have time to do a build next week. I’ll merge in the outstanding prs

On Mar 26, 2024, at 12:12 PM, ryan-westenhover @.***> wrote:

 Description

This PR fixes a memory leak that was happening in Insight.Database.CodeGenerator.DbReaderDeserializer caused by GetHashCode not being implemented in the OneToOne mapping class.

There is an existing pre-calculated _hashCode field that looks appropriate for this class, but it was never exposed through the GetHashCode method. This led to an issue where the static ConcurrentDictionary _deserializers in DbReaderDeserializer that is caching the deserializers was not recognizing that a deserializer already exists for a particular reader when checking if it needs to add a new one, ultimately leading to new deserializers accumulating in that cache over time and never getting released.

Checklist

Please make sure your pull request fulfills the following requirements:

• Tests for any changes have been added (for bug fixes / features).
• Docs have been added / updated (for bug fixes / features).

Type

This pull request includes what type of changes?

• Bug.
• Feature.
• Code style update (formatting, local variables).
• Refactoring (no functional changes, no api changes).
• Documentation content changes.
• Other (please describe below).

Breaking Changes

Does this pull request introduce any breaking changes?

• Yes
• No

Any other comment

(n/a)

---

You can view, comment on, or merge this pull request online at:

https://github.com/jonwagner/Insight.Database/pull/506

Commit Summary

• 52ce940https://github.com/jonwagner/Insight.Database/pull/506/commits/52ce9401e138b44df4174bfbab33e98772523614 Implement OneToOne.GetHashCode() to fix a memory leak

File Changes

(2 fileshttps://github.com/jonwagner/Insight.Database/pull/506/files)

• M Insight.Database.Core/Structure/OneToOne.cshttps://github.com/jonwagner/Insight.Database/pull/506/files#diff-d9fa569c2aa0476dc5c4004462e8536fffd523c9481c95f183071bf9b5b2f9a1 (9)
• M Insight.Tests/StructureTests.cshttps://github.com/jonwagner/Insight.Database/pull/506/files#diff-8d363684dac8ec520c6e848d22d5bf17aca140a176f625db574fbec3a5fce8fc (72)

Patch Links:

• https://github.com/jonwagner/Insight.Database/pull/506.patch
• https://github.com/jonwagner/Insight.Database/pull/506.diff

— Reply to this email directly, view it on GitHubhttps://github.com/jonwagner/Insight.Database/pull/506, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAMTO5ADKOGJTZ6GVGIQXLLY2GM5JAVCNFSM6AAAAABFJHYQ4OVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYDQNRYGQ2TSNQ. You are receiving this because you are subscribed to this thread.Message ID: @.***>