search

jonwagner / Insight.Database

Fast, lightweight .NET micro-ORM
Other
861 stars 145 forks source link

Support for dotnet framework4.8 #517

Open Daniel12321 opened 4 months ago

Daniel12321 commented 4 months ago

We are using Insight Database in a dotnet4.8 framework project. Is it possible to get support for this version in 8.0.1 and up?

jonwagner commented 4 months ago

Ah - I didn't realize that Microsoft was keeping net48 alive with versions of the Windows OS.

Unfortunately, I currently don't have regular access to a Windows machine for builds, so it will take me some time to get that set up again. But Insight v6 and v8 are mostly identical so you can use that for now.

jfrank14 commented 2 months ago

+1 for this. I'm using .net framework 4.8 as well and nuget is nagging me to upgrade but I can't, because of this issue.

jonwagner commented 2 months ago

I'm going to try this to clean up the build process:

https://stu.dev/dotnet-framework-reference-assemblies-via-nuget/

jonwagner commented 2 months ago

@jfrank14 @Daniel12321

can one of you try the build off of this branch:

https://github.com/jonwagner/Insight.Database/compare/net48

jfrank14 commented 2 months ago

I checked out this branch and it built successfully. Was there anything else you wanted to know about the build?

jonwagner commented 2 months ago

I know the branch builds but I don't have a .net 4.8 project to test it in. it would be great just to get a sanity check that it works there.

jfrank14 commented 2 months ago

Is it enough to replace the Insight* files in the bin folder? The only way I know there's an issue is that NuGet won't let me upgrade, but to test that would require publishing to NuGet.

jonwagner commented 2 months ago

Yeah probably

On Sep 12, 2024, at 4:38 PM, jfrank14 @.***> wrote:



Is it enough to replace the Insight* files in the bin folder? The only way I know there's an issue is that NuGet won't let me upgrade, but to test that would require publishing to NuGet.

— Reply to this email directly, view it on GitHubhttps://github.com/jonwagner/Insight.Database/issues/517#issuecomment-2347196352, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAMTO5BAE7VM6UGANT2P7GLZWH3S7AVCNFSM6AAAAABKYXYSBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBXGE4TMMZVGI. You are receiving this because you were assigned.Message ID: @.***>

jonwagner commented 2 months ago

actually...I can do a prerelease build and you can test it.

jonwagner commented 2 months ago

ok... I pushed version 8.0.2-beta1. That should contain the net48 versions. LMK if that works and I'll convert it to a release build.

jfrank14 commented 2 months ago

I just tried that beta version on a 4.8 project and it upgraded. I haven't tried to run it yet, because there are some other reference issues, but does knowing that NuGet worked answer enough of the question for you, or do you also want confirmation that it runs without error?

jfrank14 commented 2 months ago

I just tried that beta version on a 4.8 project and it upgraded. I haven't tried to run it yet, because there are some other reference issues, but does knowing that NuGet worked answer enough of the question for you, or do you want confirmation that it runs without error?