fix(search): the function is async which makes the output a promise

jonyw4 / pagarme-js-types

📖 A simple typescript definition file for pagarme-js repository

Apache License 2.0

45 stars 14 forks source link

fix(search): the function is async which makes the output a promise #39

Closed italodeandra closed 4 years ago

italodeandra commented 4 years ago

This is a hotfix. I created the PR earlier with the outdated branch by mistake. I'm thinking of some kind of way to do automated tests but for a "types" project this perhaps isn't possible. Does anyone have any idea of that?

italodeandra commented 4 years ago

Implemented a new feature (20af027) on the type that will figure out which type will be returned by the Promise with the property type informed on the query.

jonyw4 commented 4 years ago

@italodeandra eu nunca usei nenhum tipo de test para type. O único que vi, foi desse repositório, mas nunca cheguei a testar ou usar. De qualquer forma eu não sei se teria como fazermos algo do tipo, já que a biblioteca fica em outro repositório, e a documentação tbm. Mas estou sempre aberto a sugestões ou ideias. Se você tiver alguma, por favor envie!

github-actions[bot] commented 4 years ago

:tada: This PR is included in version 2.3.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: