jonz94 / Sarasa-Gothic-Nerd-Fonts

Nerd fonts patched Sarasa Gothic font.
MIT License
206 stars 10 forks source link

Minor bugs in Windows #10

Closed YujiaCheng1996 closed 1 year ago

YujiaCheng1996 commented 1 year ago

image In Windows Terminal with ohmyposh. v0.37.0

Originally posted by @YujiaCheng1996 in https://github.com/jonz94/Sarasa-Gothic-Nerd-Fonts/issues/8#issuecomment-1232326269

Some are shorter.

image In VS Code Terminal PowerShell. v0.37.0 Last One is not complete (half width).

jonz94 commented 1 year ago

Hi, Thanks for reporting the issue.

I found the issue is caused by latest version (v2.2.1) of nerd fonts. So I downgrade nerd fonts back to v2.1.0 (2445b4958fe1c8a92641fd0abec5293e0dfa4d7a) and release the new version v0.37.0-0

You could try it out and see if the issue is resolved.

Extra information

Screenshots of my Windows Terminal with v0.37.0-0

Windows Terminal screenshots

VS Code Integrated Terminal

screenshots of VS Code Integrated Terminal with issue occured

screenshots of VS Code Integrated Terminal with issue fixed

YujiaCheng1996 commented 1 year ago

The height is correct now, but  is still cut off in both Windows Terminal and VSCode with their gpuAcceleration turned off v0.37.0-0. Maybe it's their issue. image

jonz94 commented 1 year ago

The height is correct now, but  is still cut off in both Windows Terminal and VSCode with their gpuAcceleration turned off

I think this issue can be fixed by tweaking your oh-my-posh settings.

You can simply adding an extra space after the  icon (\uF469)

-          "template": "\uF469"
+          "template": "\uF469 "

Screenshots

Before

before-adding-space

After

after-adding-space

YujiaCheng1996 commented 1 year ago

That's a good workaround.