search

jooby-project / jooby

The modular web framework for Java and Kotlin
https://jooby.io
Apache License 2.0
1.7k stars 199 forks source link

Conscrypt should not be included by default #3435

Closed ogrammer closed 4 months ago

ogrammer commented 4 months ago

When using jooby-jetty, jooby-conscrypt and org.eclipse jetty-alpn-conscrypt-server get included. On the website it says that if you want conscrypt you need to add it manually but this is automatic. I have to exclude conscrypt in my build configuration to get rid of it.

Please make it so that conscrypt is not included by default

jknack commented 4 months ago

There is no jooby-conscrypt dependency on jooby-jetty:

[INFO] --- dependency:3.6.1:tree (default-cli) @ jooby-jetty ---
[INFO] io.jooby:jooby-jetty:jar:3.1.2-SNAPSHOT
[INFO] +- io.jooby:jooby:jar:3.1.2-SNAPSHOT:compile
[INFO] |  +- com.github.spotbugs:spotbugs-annotations:jar:4.8.5:compile
[INFO] |  |  \- com.google.code.findbugs:jsr305:jar:3.0.2:compile
[INFO] |  +- org.slf4j:slf4j-api:jar:2.0.13:compile
[INFO] |  +- jakarta.inject:jakarta.inject-api:jar:2.0.1:compile
[INFO] |  \- com.typesafe:config:jar:1.4.3:compile
[INFO] +- org.eclipse.jetty.websocket:jetty-websocket-jetty-api:jar:12.0.9:compile
[INFO] +- org.eclipse.jetty.websocket:jetty-websocket-jetty-server:jar:12.0.9:compile
[INFO] |  +- org.eclipse.jetty:jetty-server:jar:12.0.9:compile
[INFO] |  |  \- org.eclipse.jetty:jetty-http:jar:12.0.9:compile
[INFO] |  +- org.eclipse.jetty.websocket:jetty-websocket-core-server:jar:12.0.9:compile
[INFO] |  |  \- org.eclipse.jetty.websocket:jetty-websocket-core-common:jar:12.0.9:compile
[INFO] |  \- org.eclipse.jetty.websocket:jetty-websocket-jetty-common:jar:12.0.9:compile
[INFO] +- org.eclipse.jetty.http2:jetty-http2-server:jar:12.0.9:compile
[INFO] |  \- org.eclipse.jetty.http2:jetty-http2-common:jar:12.0.9:compile
[INFO] |     \- org.eclipse.jetty.http2:jetty-http2-hpack:jar:12.0.9:compile
[INFO] +- org.eclipse.jetty:jetty-alpn-java-server:jar:12.0.9:compile
[INFO] |  +- **org.eclipse.jetty:jetty-alpn-server:jar:12.0.9:compile**
[INFO] |  \- org.eclipse.jetty:jetty-io:jar:12.0.9:compile
[INFO] |     \- org.eclipse.jetty:jetty-util:jar:12.0.9:compile
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.10.2:test
[INFO] |  |  +- org.opentest4j:opentest4j:jar:1.3.0:test
[INFO] |  |  \- org.junit.platform:junit-platform-commons:jar:1.10.2:test
[INFO] |  +- org.junit.jupiter:junit-jupiter-api:jar:5.10.2:test
[INFO] |  \- org.apiguardian:apiguardian-api:jar:1.1.2:test
[INFO] \- org.jacoco:org.jacoco.agent:jar:runtime:0.8.12:test
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.673 s
[INFO] Finished at: 2024-05-26T13:34:40-03:00
[INFO] ------------------------------------------------------------------------
ogrammer commented 4 months ago

Ok, in version 3.0.7 this was a problem but with 3.0.8 it is no longer a problem. I had updated but had to revert due to the buffer bug introduced in 3.1.0 so I did not check well.