jooby-project / jooby

The modular web framework for Java and Kotlin
https://jooby.io
Apache License 2.0
1.71k stars 197 forks source link

mvn jooby:run with multiple modules dependencies does not reload #447

Closed nfleury closed 8 years ago

nfleury commented 8 years ago

Working with multiple module dependencies and jooby:run does not work.

I have the following project structure:

parent-project |_model |_service |_app (contains jooby project)

mvn jooby:run works fine with reload on changes in app folder but I would like jooby:run to reload when when making changes in model or service.

I tried many configurations with build-helper-maven-plugin to add model and service as sources, that did not work, I also tried to include model and services sources with jooby configuration "" it did not worked either ...

Thanks

jknack commented 8 years ago

done. There is a watchDirs property now, but... in theory you don't need to do anything... jooby:run now detects multi-module project and configure everything for you ;)

nfleury commented 8 years ago

Thanks for the quick update!

Running jooby:run on 'app' does include 'service' in watchDirs. Changing sources in 'service' reloads the app but only on the first change. If I edit 'service' sources more than once the application won't reload again.

jknack commented 8 years ago

@nfleury good catch!

will fix it later today.

jknack commented 8 years ago

fixed in master. Again: good catch!

nfleury commented 8 years ago

@jknack Many thanks ! Works great now !!!