joohoi / acme-dns-certbot-joohoi

Certbot client hook for acme-dns
MIT License
215 stars 65 forks source link

Refactor requests (the only dependency) out #5

Open joohoi opened 6 years ago

joohoi commented 6 years ago

While requests is awesome, there's a major benefit in not having any dependencies outside of the standard library. The refactored code should support both, Python 2 and 3. The refactoring will flow down to the published library https://github.com/joohoi/pyacmedns as well.

I would be grateful if someone is up for the task, but will handle it myself in the future if nobody is interested.

jvanasco commented 6 years ago

since this is a certbot hook... certbot uses requests itself so you can expect that it's on the user's system/virtualenv already.

BUT

if you want this for pyacmedns, the python library acme-tiny accomplishes this and is easy to modify

clayshieh commented 6 years ago

I've written a simple request clone that handles basic GET/POST requests using standard libraries that should work for this. I will submit a PR for it soon.

joohoi commented 6 years ago

Thanks! Sounds awesome!