condition checking against ACK/Jasmin

jookies / jasmin

Jasmin - Open source SMS gateway

http://jasminsms.com

Other

1.01k stars 550 forks source link

Closed rrickardt closed 1 year ago

rrickardt commented 2 years ago

Since python3/0.10 everything is handled as bytes, condition checking ACK/Jasmin response is validating against b'ACK/Jasmin', thus never validates.

Carlos314159 commented 2 years ago

I agree, the fact request.content is always in bytes makes that SMS MO to a HTTP API is never working. I vote for that PR

farirat commented 2 years ago

@rrickardt thank you for this pr ! could you please take care of the failed tests upon ci builds above ?

rrickardt commented 2 years ago

@farirat i will try to fix them in following days.

farirat commented 1 year ago

@rrickardt all tests related to the http messaging and ack handling went crazy :)

rrickardt commented 1 year ago

@farirat i will check the tests locally and let you know when it is working and ready to unblock this merge.