jookies / jasmin

Jasmin - Open source SMS gateway
http://jasminsms.com
Other
1.01k stars 550 forks source link

1401/metrics not protected #1083

Closed agossouvi closed 1 year ago

agossouvi commented 1 year ago

Hi, {IP_server}:1401/metrics is not protected.... Can you fix that ?

farirat commented 1 year ago

What do you mean by "protected" ? If it's meant to be secured with authentication then, since this is not a user-centric endpoint it must not be exposed externally, it's only for internal networks, example for observability in a kubernetes cluster. If you are exposing jasmin's 1401 port to public then you'll need to put a reverse proxy in front of it and filter incoming requests to only allow user-centric endpoints like /send, /balance ...

agossouvi commented 1 year ago

Thank you for your quick reply. Yes, it is, "insecure" is the correct term. I understand your logic.

Do you have a recommendation for the reverse proxy? Thanks.

farirat commented 1 year ago

There's no specifc requirement, can be the old good httpd or nginx, traefik ...

agossouvi commented 1 year ago

Ok, thanks !