jookies / jasmin

Jasmin - Open source SMS gateway
http://jasminsms.com
Other
1.02k stars 549 forks source link

memory leak in router/thrower lead to RabbitMQ unacked timeout #1172

Closed BlackOrder closed 8 months ago

BlackOrder commented 8 months ago

Description

The memory leak is in the thrower router. when dlr level 3 is requested: if level 1 and level 2 are both in the queue, then both have the same message-id. added a function to create a unique id [message-id-level]. when it is not a dlr it will be [message-id-]. Possible same problem in Issue #1142 i don't know enough about managers and no testing setup for it to tinker with manager/dlr. but i suspect the same problem there. @farirat, please check there. 😊👍

Checks

BlackOrder commented 8 months ago

changed the function to append the message.delivery_tag instead of level as it's universal and unique throughout the session. kept the message id for debugging and if the connection reset somehow and the message.delivery_tag changed. i'm not an expert of RabbitMQ

BlackOrder commented 8 months ago

it seems jasmin does not like delivery_tag very much

BlackOrder commented 8 months ago

Bad change. Nothing works properly. Found a fix. but i will add it in a different pull request. :(

meshackjr commented 7 months ago

still an issue