jooking / closure-library

Automatically exported from code.google.com/p/closure-library
Apache License 2.0
0 stars 1 forks source link

ModalPopup positioning causes display glitch #514

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Have an even viewSize.width & viewSize.height 
2. Use Google Chrome Version 23.0.1271.52 beta on Ubuntu 12.10
3. Display a ui.Dialog

What is the expected output? 
The dialog should show fine

What do you see instead?
There is a blank space between the border and the dialog (see attached picture)

What version of the product are you using? 
svn revision 2309

On what operating system?
Ubuntu 12.10

Please provide any additional information below.
This is caused by the .5px of the positioning (top & left) - see attached 
screenshot.

Digging into the code I have noticed that goog.style.setPosition() uses rounded 
values but for Gecko only - see goog.style.getPixelStyleValue_().

I guess Math.round() is avoided for speed reasons ? 

If this is the case, isn't computing buggyGeckoSubPixelPos (in setPosition) 
time consuming ? May be the compiler is able to "cache" the result ?

Original issue reported on code.google.com by victor.b...@gmail.com on 16 Nov 2012 at 7:00

Attachments: