joolswills / plugin.video.iplayer

This plugin is broken.
10 stars 4 forks source link

No "Genre" in programme info #162

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Go to any programme entry
2. Press "Info" button ("I" key in default keymap)
3.

What is the expected output? What do you see instead?
No "Genre" - previously it showed the iPlayer category (e.g. Factual / Science 
& Nature)

Debug log output (http://pastebin.com/)
Nothing relevant

What version of the plugin are you using? On what OS?
2.6.3 on RaspBMC (XBMC 13.2 Git:20140901-867305b)

Please provide any additional information below.

The fix is a trivial adjustment to the XML parsing code. The regular expression 
doesn't work because there are spaces and new lines between </short_name> and 
<text>. I also prefer to use the <short_name> element rather than <text> 
otherwise it doesn't fit on the screen.

--- plugin.video.iplayer/lib/listparser.py  2014-11-06 19:12:52.000000000 +0000
+++ /home/pi/.xbmc/addons/plugin.video.iplayer/lib/listparser.py    2014-11-16 
12:17:10.628025307 +0000
@@ -40,7 +40,7 @@
     re_id = re.compile("<id>(.*?)</id>", re.DOTALL)
     re_updated = re.compile("<updated>(.*?)</updated>", re.DOTALL)
     re_summary = re.compile("<synopsis>(.*?)</synopsis>", re.DOTALL)
-    re_categories = re.compile("<category.*?</short_name><text>(.*?)</text>", 
re.DOTALL)
+    re_categories = 
re.compile("<category.*?<short_name>(.*?)</short_name>.*?</category>", 
re.DOTALL)
     re_thumbnail = re.compile("<my_image_base_url>(.*?)</my_image_base_url>", re.DOTALL)
     re_series = re.compile("<link rel=\"related\" href=\".*microsite.*title=\"(.*?)\" />", re.DOTALL)

Original issue reported on code.google.com by blaise.s...@gmail.com on 16 Nov 2014 at 12:31

GoogleCodeExporter commented 9 years ago
thanks. fixed in r204

Original comment by exob...@gmail.com on 17 Nov 2014 at 9:26