search

joomcode / BottomSheet

Bottom Sheet for iOS
https://medium.com/joomtech/bottom-sheet-shall-we-drop-the-formalities-400515255829
MIT License
309 stars 47 forks source link

navigationcontroller init problem in iOS 12 #18

Closed mohabbasi1213 closed 1 year ago

mohabbasi1213 commented 1 year ago

Fatal error: Use of unimplemented initializer 'init(nibName:bundle:)' for class 'BottomSheet.BottomSheetNavigationController'

mikhailmaslo commented 1 year ago

Hi, it's not intended for storyboard usage

mohabbasi1213 commented 1 year ago

this is happening for me on iOS 12 for BottomSheetDemo on the project. but it is working properly on iOS 16.

mikhailmaslo commented 1 year ago

Do you use it inside a Storyboard?

mohabbasi1213 commented 1 year ago

No, I run your demo without any storyboard file inside the project.

mikhailmaslo commented 1 year ago

Can you tell me your Xcode version?

mohabbasi1213 commented 1 year ago

Version 14.2 (14C18) test device: iPhone 6 - iOS 12.4.9

luka-w commented 1 year ago

Same problem, xCode 14.3, device: iPhone 5S, iOS 12.5.7

mikhailmaslo commented 1 year ago

It should be fixed as soon as we merge https://github.com/joomcode/BottomSheet/pull/21

mikhailmaslo commented 1 year ago

Should be fixed in main and release 2.0.3

Feel free to reopen, if it's the case