joomdev / Astroid-Framework

Powerful framework for designers and developers to create responsive, fast & robust Joomla based websites and templates.
https://github.com/templaza/astroid-framework
GNU General Public License v2.0
105 stars 43 forks source link

Expired label always display (j4) #171

Closed micker closed 4 years ago

micker commented 4 years ago

hello i use j4 beta 3 + asteroid + template one article always display expired after title <span class="label label-warning">Expired</span> i switch to cassopedian nothing thanks for all

micker commented 4 years ago

No news ?

micker commented 4 years ago

@chetanmadaan @hiteshaggarwal ?

hiteshaggarwal commented 4 years ago

Hi @micker , I am really sorry for delayed reply. Astroid is based on Bootstrap v4 so you must user badge instead of label. See https://getbootstrap.com/docs/4.5/migration/#labels-and-badges

Thanks, Hitesh

micker commented 4 years ago

the problem isn't a css problem but why astroid display this (unwanted) and core template none ?

chetanmadaan commented 4 years ago

Hi @micker, You can see the expired html should only appear is the finish publishing date is in the past https://github.com/joomdev/Astroid-Framework/blob/master/astroid/astroid-template-one/html-j4/com_content/article/default.php#L66-L68 I can't reproduce this on J3, @Nishtha003 can you see if the above HTML is visible on default article on a basic Joomla 4 install with Astroid?

micker commented 4 years ago

I already test this no date in unpublish field and if i actived cassopedia nothing was display

micker commented 4 years ago

image in front image backend

chetanmadaan commented 4 years ago

Got it. @Nishtha003 Are you able to reproduce this as well?

micker commented 4 years ago

i found i didn't see the action to rename html and html-j4 ... that solve it

chetanmadaan commented 4 years ago

Thanks @micker the next release of astroid is going to have a J4 installer as well, which will specifically have J4 overrides.