search

joomdev / Astroid-Framework

Powerful framework for designers and developers to create responsive, fast & robust Joomla based websites and templates.
https://github.com/templaza/astroid-framework
GNU General Public License v2.0
104 stars 43 forks source link

Social Profiles brand colour - better description #75

Open shoulders opened 5 years ago

shoulders commented 5 years ago

image

Once I figured out what this was for it made sense, however becasue I choose on github nothing changed and this confused me.

Could you add a small note on to this option to make it clearer that the 'style' option of 'Brand Colour' means that it will take that companys default icon colour such as the facebook icon will go blue and the spotify icon will go green.

Same for the documentation here: https://docs.joomdev.com/article/astroid-social-profile/

The video does address this and shows you what happens.

chetanmadaan commented 5 years ago

This is on me! Will update the language and documentation as well.

itxchandan commented 5 years ago

@shoulders

GitHub's brand color is black, therefore you could't see the changes. To see the brand color try adding YouTube, Facebook, Spotify or any other profiles whose brand color is not black.

shoulders commented 5 years ago

@chandanndeep I address the issue you mention in #76

My issue here was just to explain to the end user that Brand Colour means the colour of that companies icon, not a brand colour that you set for yourself for the astroid zero template. I did actually go looking becasue some templates have preset colour schemes and this is what I tought you were referering to.

itxchandan commented 5 years ago

@shoulders

Alright, we have updated it in the documentation. https://docs.joomdev.com/article/astroid-social-profile/

shoulders commented 5 years ago

maybe update the text next to the drop down to something like: (assumes you add in the other option)

Style Choose the colour scheme for your social media icons. Inherit will use the templates colour for that area, Brand with use the relative companies colour scheme and custom you can select your own colour for all of the icons.

chetanmadaan commented 5 years ago

maybe update the text next to the drop down to something like: (assumes you add in the other option)

Style Choose the colour scheme for your social media icons. Inherit will use the templates colour for that area, Brand with use the relative companies colour scheme and custom you can select your own colour for all of the icons.

Thanks.

itxchandan commented 5 years ago

@shoulders

I have highlighted the notice. Please have a look.

image

shoulders commented 5 years ago

Does this read better? What do you think?

Option 1 (icon specific) Style: Choose the style for how you to want to present your Social Profile on your site. The default value is Inherit Color (icon colour is inherited from the template) and the other option is Brand Color (the icon colour is taken from the companies relative colour scheme).

Option 2 (non-specific) Style: Choose the style for how you to want to present your Social Profile on your site. The default value is Inherit Color (colour is inherited from the template) and the other option is Brand Color (colour is taken from the companies relative colour scheme).

Option 3 (styling) Style: Choose the style for how you to want to present your Social Profile on your site. The default value is Inherit Color (styling is inherited from the template) and the other option is Brand Color (styling is taken from the companies relative colour scheme).

I dont know if a separate warning is needed (see my new texts above) however it is very obvious. If kept perhaps this is a better wording.

Brand Colors will use the companies relative colour scheme for the icon. Brand Colors will use the companies relative colour scheme. Brand Colors will use the companies relative colour scheme for styling.

In reguards the spelling of colour.

The message at the bottom, does this read better?

We have in all 20+ types of Predefined Social Profiles to which you can add your own additional custom Social Profiles.

P.S. I think you guys work long hours.

chetanmadaan commented 5 years ago

Thanks Jon. This looks much better. I'll go ahead and update documentation based on this very soon.

Thanks again for all you have done so far.