Global custom code field for templates

joomdev / Astroid-Framework

Powerful framework for designers and developers to create responsive, fast & robust Joomla based websites and templates.

https://github.com/templaza/astroid-framework

GNU General Public License v2.0

104 stars 43 forks source link

Global custom code field for templates #92

Open shoulders opened 5 years ago

shoulders commented 5 years ago

I dont know if this is going to be a real issue but I am just thinking ahead.

In the template options you have the custom code feature (which is brilliant) but it is per template style. As you can see in the image I have Google anayltics code in there. If I only every use one or 2 styles this will not be an issue. However if I then have 10 styles and for some reason I change the google anayltics or want to add another script I will have to add it 10 times.

This is not the end of the world and to be honest I will never do anything that complex but here are a few Ideas

a button to copy the code in the 'tracking code'
have these options availabe somewhere as a global option
I could use a plugin outside of the template
on the 'custom code' page there would be the section and fields now, but also them replicated as a global option where these optionis are shared across all asteroid templates.

Thanks

chetanmadaan commented 5 years ago

Hello,

Couple of options here.

You can insert Analytics code directly into one of the layout files and override them https://docs.joomdev.com/article/frontend-folder-overrides/
Use a 3rd party plugin to insert Analytics code instead of template settings so it's applicable across all templates & styles. https://extensions.joomla.org/category/site-management/analytics/

Thanks,

shoulders commented 5 years ago

tracking code was example. perhaps I should of said CSS code. perhaps add and editor for the custom.css , custom.js, custom.scss directly in this section

shoulders commented 5 years ago

I think this should be re-looked at

You could have another tab called 'Global Code' and this would be treated like a static variable in a PHP class.

You could also tie this in with editing custom.css, custom.scss and custom.js with in the template by making these files (+header.html) the repositories for the code

chetanmadaan commented 5 years ago

tracking code was example. perhaps I should of said CSS code. perhaps add and editor for the custom.css , custom.js, custom.scss directly in this section

You can edit files using Joomla's template system. remember, we want to offer the functionality but not re-invent the whell.

chetanmadaan commented 5 years ago

I think this should be re-looked at

You could have another tab called 'Global Code' and this would be treated like a static variable in a PHP class.

You could also tie this in with editing custom.css, custom.scss and custom.js with in the template by making these files (+header.html) the repositories for the code

Let's re-look at it. I have reopened the task.

chetanmadaan commented 5 years ago

I am just looking at this from an end (naive), user's point of view, he wouldn't know how to make sense of all this.

shoulders commented 5 years ago

I completely understand butI think an end user who is using a template framework to build his site should know the difference between global and page specific rules. However I bet you guys have to deal with more end users than me. lol

Some Reasons for a global code tab

same tracking code on all pages
user might want to add an inline custom script to all pages
CSS is very complex, if you try and made single edits to everypage, things might get out of sync

If this is not possible it is not a game changer and I could live without, but I could also use this feature at the same time.

You guys definately do not have to re-invent the wheel, if you did it probably would be well designed, like this framework. I might have point out a load of isses and features but it really is great and will make the transition to Joomla 4 very easy becasue of the naked/clean bootstrap code.