search

joomla-extensions / jedchecker

Joomla extension to check components, modules or plugins for possible problems for submission to the JED -> Translations: https://joomla.crowdin.com/joomla-official-extensions
38 stars 28 forks source link

Add error-level badges #157

Closed dryabov closed 2 years ago

dryabov commented 2 years ago

Fix issue #154.

conconnl commented 2 years ago

Did you add the font-awesome default icons in front of it?

dryabov commented 2 years ago

Did you add the font-awesome default icons in front of it?

No.

I tried to add Bootstrap icons as SVG (the FontAwesome SVG icons are released under CC BY 4.0 and require to indicate all changes made, even if it's just a change of width/height attributes, and Bootstrap icons are MIT licensed), but the result doesn't look good (IMHO), mostly because of the varying heights of alert blocks (I tried both top and center vertical alignment). And they are quite annoying in the case of long issue lists.

conconnl commented 2 years ago

Joomla Core uses Font-Awesome for what I have seen. It should not be a problem too use it. Could you check to be sure?

dryabov commented 2 years ago

Joomla 3 is shipped with IcoMoon icons, and Joomla 4 has FontAwesome instead. I wouldn't like to have two different code branches for different Joomla versions to just display an icon (that will consume significant part of screen width on mobiles).

anibalsanchez commented 2 years ago

In similar cases, I use to embed the SVGs. It is only a few Kbs and 4 files.