Closed dryabov closed 2 years ago
I see there is a typo at /views/uploads/tmpl/default.php
can you add the fix for that also to this pr.
I see there is a typo at
/views/uploads/tmpl/default.php
can you add the fix for that also to this pr.
Looks like a merging bug in GitHub, because I have a correct file locally (and I'd mark it reviewing the patch by Dimitris https://github.com/joomla-extensions/jedchecker/pull/176/files that is correct too).
Current version of the file is correct: https://github.com/joomla-extensions/jedchecker/blob/develop/administrator/components/com_jedchecker/views/uploads/tmpl/default.php
My patch doesn't change that line at all: https://github.com/joomla-extensions/jedchecker/pull/177/files
So, I'm not sure where it may come from.
Wow... weird, I was not sure what to make of it either.
Got it. The "?" comes from the first commit in the Dimitris's PR #176, but it's fixed in a subsequent commit (see https://github.com/joomla-extensions/jedchecker/pull/176/commits/9d12ef26e19e6ae90f11d636818b2362fac207f4).
Well in the develop branch its still not fixed (why I have no idea)... so we need to fix it.
The current state of the development branch is correct: https://github.com/joomla-extensions/jedchecker/blob/develop/administrator/components/com_jedchecker/views/uploads/tmpl/default.php
JHtml
-basedstyle
andstylesheet
functions)self::CLEAN_HTML | self::CLEAN_COMMENTS
inJEDCheckerHelper
)