joomla-extensions / jedchecker

Joomla extension to check components, modules or plugins for possible problems for submission to the JED -> Translations: https://joomla.crowdin.com/joomla-official-extensions
38 stars 28 forks source link

Check required minimal Joomla! and PHP version #177

Closed dryabov closed 2 years ago

dryabov commented 2 years ago
Llewellynvdm commented 2 years ago

I see there is a typo at /views/uploads/tmpl/default.php can you add the fix for that also to this pr.

https://github.com/joomla-extensions/jedchecker/blob/50ca5ba19ab73db1d5dd3a06db25f30fde752f07/administrator/components/com_jedchecker/views/uploads/tmpl/default.php#L47

dryabov commented 2 years ago

I see there is a typo at /views/uploads/tmpl/default.php can you add the fix for that also to this pr.

https://github.com/joomla-extensions/jedchecker/blob/50ca5ba19ab73db1d5dd3a06db25f30fde752f07/administrator/components/com_jedchecker/views/uploads/tmpl/default.php#L47

Looks like a merging bug in GitHub, because I have a correct file locally (and I'd mark it reviewing the patch by Dimitris https://github.com/joomla-extensions/jedchecker/pull/176/files that is correct too).

dryabov commented 2 years ago

Current version of the file is correct: https://github.com/joomla-extensions/jedchecker/blob/develop/administrator/components/com_jedchecker/views/uploads/tmpl/default.php

My patch doesn't change that line at all: https://github.com/joomla-extensions/jedchecker/pull/177/files

So, I'm not sure where it may come from.

Llewellynvdm commented 2 years ago

Wow... weird, I was not sure what to make of it either.

dryabov commented 2 years ago

Got it. The "?" comes from the first commit in the Dimitris's PR #176, but it's fixed in a subsequent commit (see https://github.com/joomla-extensions/jedchecker/pull/176/commits/9d12ef26e19e6ae90f11d636818b2362fac207f4).

Llewellynvdm commented 2 years ago

Well in the develop branch its still not fixed (why I have no idea)... so we need to fix it.

dryabov commented 2 years ago

The current state of the development branch is correct: https://github.com/joomla-extensions/jedchecker/blob/develop/administrator/components/com_jedchecker/views/uploads/tmpl/default.php