search

joomla-extensions / jedchecker

Joomla extension to check components, modules or plugins for possible problems for submission to the JED -> Translations: https://joomla.crowdin.com/joomla-official-extensions
38 stars 28 forks source link

NOTICE: Node <folder> has unknown attribute 'plugin' is wrong? #202

Closed peterhulst closed 1 year ago

peterhulst commented 1 year ago

Hello, When validating plugin "contentnotifier" the XML Manifests has NOTICE: Node has unknown attribute 'plugin' is displayed.

This is for line: <folder plugin="contentnotifier">services</folder> in:

`

services 
        <folder>language</folder>
        <folder>src</folder>
    </files>`

However removing plugin="contentnotifier" from that line giving: <folder>services</folder> gives during installation:

Plugin Install: Field 'element' doesn't have a default value Error installing plugin

So I think that the NOTICE is wrong, because the plugin works correctly with: <folder plugin="contentnotifier">services</folder>

Regards, Peter

dryabov commented 1 year ago

Fixed in PR #204 for plugins and modules (along with other related improvements)

peterhulst commented 1 year ago

I checked this and it works correctly now. Thank you!