search

joomla-extensions / patchtester

Patch testing extension for the Joomla! CMS
https://issues.joomla.org
GNU General Public License v2.0
48 stars 44 forks source link

Joomla [5.0] #353

Closed chmst closed 1 year ago

chmst commented 1 year ago

Steps to reproduce the issue

Install Patchtester on a Joomla 5.0 and try to fetch data:

grafik

Expected result

Actual result

System information (as much as possible)

Additional comments

deltapapa01 commented 1 year ago

Confirm, when push RESET i get this error:

PatchTester\Model\PullModel::__construct(): Argument #2 ($db) must be of type ?JDatabaseDriver, Joomla\Database\Mysqli\MysqliDriver given, called in /html/cms/administrator/components/com_patchtester/PatchTester/Controller/ResetController.php on line 42

bayareajenn commented 1 year ago

Same. I can confirm in 5.0.0a4. Thanks for opening an issue Christiane. image What do you reckon @roland-d?

alikon commented 1 year ago

please test #354

roland-d commented 1 year ago

@bayareajenn I am looking into this. Github never sends me notifications on this repo, so thank you for tagging me :)

roland-d commented 1 year ago

@chmst @deltapapa01 @chmst @alikon I put out a new release of the patch tester, version 4.2.2 that should address these issues and a few more. Care to give it a try?

bayareajenn commented 1 year ago

@roland-d So much better. It installs now and will take my token and fetch issues. YAY!!

However, I can only load five pages of issues. Is that by design? So if I want to test issue 41104, I cannot. image

Thoughts?

roland-d commented 1 year ago

@bayareajenn Do you get any error? Perhaps an error while loading the issues? When I fetch data I get 14 pages of issues. You can check the requests by opening the developer tools in your browser (usually by pressing F12 or right click and choose Inspect). On the network tab you will see the requests go by as you fetch issues. These should all end in a status of 200.

I wonder if anybody else has this issue.

chmst commented 1 year ago

I got 14 pages - xampp, win11 and php 8.2. Could the php version make a difference?

bayareajenn commented 1 year ago

@roland-d Everything in the network tab has a status of 200 when I fetch issues. I'll figure it's just me and we can carry on. I can install the ci packages with the pr when I need to test something. As long as normal people at PB&F can load all the issues, all good. Thank you for your quick work on the package and having it ready for J5!! You rule!! <3

roland-d commented 1 year ago

@bayareajenn 5 pages seem to indicate only 1 step completed. If you know how, can you check the response in the network tab of the first page indexing. Curious to know what it says.

Do you see 3 pages being indexed or just 1?

bayareajenn commented 1 year ago

I PMd you @roland-d cuz I think I'm just seeing 1 page indexed but I am not great at reading the network tab.

bayareajenn commented 1 year ago

Roland and I chatted about this and have determined that the response issue only showing me five pages is an issue on my server. All good! Let's move on! Thanks Rolando!!! <3