joomla-extensions / patchtester

Patch testing extension for the Joomla! CMS
https://issues.joomla.org
GNU General Public License v2.0
48 stars 44 forks source link

[4.3.1]: The Filter RTC Patches 'No' filter does not work... #371

Closed exlemor closed 2 months ago

exlemor commented 7 months ago

Steps to reproduce the issue

I have Joomla 5.1.0-beta1 installed (i'm testing Patches for 5.1 RC).

I am in the Joomla Patch Tester and I want to filter my view to only see 5.1-dev and RTC Patches set to: No.

Expected result

I see a list that only contains 5.1-dev and Ready to Commit: No

Actual result

I see a list that only contains 5.1-dev and Ready to Commit: Yes and No. ;(

Ironically, if you select Filter RTC: Yes, it works perfectly and shows only Yes results...

System information (as much as possible)

PHP 8.2.17, MySQL 8.0.36 Joomla 5.1-dev

Additional comments

Joomla-Patch-Tester-RTC-set-to-Yes

Joomla-Patch-Tester-RTC-set-to-No

alikon commented 7 months ago

should be fixed in https://github.com/joomla-extensions/patchtester/pull/365

exlemor commented 7 months ago

Hi @alikon, thanks, but stupid question since #365 says it is merged back in Sept. 2023 does that mean that a new version needs to be released of Joomla Patch Tester that will include this fix or that the fix at that time, missed this issue?

alikon commented 7 months ago

does that mean that a new version needs to be released of Joomla Patch Tester that will include this fix

yes

fgsw commented 2 months ago

Should the issue be closed as there is the (merged) pull request #365?

roland-d commented 2 months ago

Hi, a new release has just been put out with this fix included.