joomla-extensions / pkg_languagepack

3 stars 10 forks source link

Update XML not showing the highest version #72

Closed conconnl closed 2 years ago

conconnl commented 3 years ago

@Llewellynvdm The update XML shows the last uploaded version, not the highest one. https://update.joomla.org/language/translationlist_4.xml

I would expect it shows the incremental versions. Which means 4.0.1.1 instead of 4.0.0.10 for English AU. https://downloads.joomla.org/language-packs/translations-joomla4/downloads/joomla4-english-australia

Can you take a look? CC @particthistle

Llewellynvdm commented 3 years ago

Hmm we are not modeling the version but taking it directly from the system.

As you can see here https://github.com/joomla-extensions/pkg_languagepack/blob/master/com_languagepack/site/models/export.php#L185

This should mean the data is not correct in the database.... well that is what I think, it is not the export making changes.

Llewellynvdm commented 3 years ago

So @wilsonge here we do declare to be latest ... why does it return the 4.0.0.10 and not 4.0.1.1? @conconnl is there a 4.0.1.1 in the system?

conconnl commented 3 years ago

The order display on the website seems to be the order of upload. That is probably why 4.0.0.10 is in the xml instead of 4.0.1.1 as the .10 was uploaded as last one.

Llewellynvdm commented 3 years ago

So its not using the version number to see what is the latest... but the upload date. Should this change?

particthistle commented 3 years ago

(See note on issue 71)[https://github.com/joomla-extensions/pkg_languagepack/issues/71#issuecomment-905188966]

@Llewellynvdm wrote:

why does it return the 4.0.0.10 and not 4.0.1.1? The language packs in the list are manually populated by the proofreader doing the upload, and as @conconnl indicated, currently it's displayed by order of upload not version - that's how it should be IMO... I just broke the version ordering by mixing things up.

So in the example:

Additional notes:

Having discovered all the above during the process, it's being added to Proofreader instructions to ensure all of it's covered by new proofreaders going forward.

wilsonge commented 3 years ago

https://github.com/joomla/joomla-cms/commit/8e6f8d463ff0f20eba4958e2534ad9664553d938 install.xml added for the next release

HLeithner commented 2 years ago

Seems to be fixed. I'm closing this.