search

joomla-extensions / weblinks

This repo is meant to hold the decoupled com_weblinks component and related code.
GNU General Public License v2.0
45 stars 88 forks source link

Fix RoboFile on Windows #381

Closed Bakual closed 5 years ago

Bakual commented 6 years ago

Pull Request for Issue #361 .

Summary of Changes

Wraps the code into a try/catch which will return '' in case a fatal error was discovered.

Testing Instructions

Try to build the weblinks package by running vendor/bin/robo.bat buildon a Windows machine. Of course first make sure to have composer stuff installed.

Expected result

Packages are created in /dist

Actual result

Fatal Error

Documentation Changes Required

We need better documentation on how to build the packages anyway. There is documentation on how to run the tests, but I didn't found explanantions how to actually build the packages.

Bakual commented 6 years ago

Actually, it only fixes the creating of dist/weblinks-3.7.0. I don't get the zipfiles created.

astridx commented 6 years ago

Everything fits in Ubuntu :) Hopefully this will also test someone under Windows.