search

joomla-extensions / weblinks

This repo is meant to hold the decoupled com_weblinks component and related code.
GNU General Public License v2.0
45 stars 88 forks source link

Don't strip Time info #387

Closed okonomiyaki3000 closed 2 years ago

okonomiyaki3000 commented 6 years ago

There is no need to strip the time info from the created column. This information might be useful in case of timezone differences or whatever. Let the formatting be done at the template level.

Pull Request for Issue # .

Summary of Changes

Removed this from the database query: DATE_FORMAT(a.created, "%Y-%m-%d") AS created

Because why wouldn't you want the full datetime info?

Testing Instructions

Create a weblinks module. It should display the same way with or without the patch.

Expected result

No direct change expected.

Actual result

No direct change actually.

Documentation Changes Required

No

okonomiyaki3000 commented 6 years ago

I'm sure that this failure has nothing to do with me. Isn't there a problem with Travis?

okonomiyaki3000 commented 6 years ago

Hello? Somebody want to have a look at this? This build failure has nothing to do with this PR. Please fix your Travis and run it again.

okonomiyaki3000 commented 6 years ago

Hey! Fix your travis and merge this patch, ok?

okonomiyaki3000 commented 6 years ago

:pineapple:

okonomiyaki3000 commented 6 years ago

Hello? Anybody home in here? Your Travis is drunk and this a solid improvement. Let's get it merged.

mbabker commented 6 years ago

Is this the appropriate time to open the infamous "is this repo abandoned" issue?

yvesh commented 6 years ago

Needs at least one test, than I merge it. Not sure if there was a reason to add the strip before hand.

alikon commented 6 years ago

despite Travis it works as expected

okonomiyaki3000 commented 6 years ago

@yvesh It looks like @alikon has tested it but is there some official way to report a successful test?

okonomiyaki3000 commented 5 years ago

Just take this damn patch. It's obviously nonsense to strip the time information here. Why would you do that?

alikon commented 5 years ago

i'm afraid this is abandonware

zero-24 commented 5 years ago

@wilsonge and @HLeithner should have the propper access to merge things here :)

joomdonation commented 2 years ago

Thanks. Merging this because the change here is valid and we did the same change for the version for Joomla 4 sometime ago. However, as Joomla 3 is now in maintenance mode, I guess we won't release new version for Joomla 3 unless there are requests from other users.