joomla-extensions / weblinks

This repo is meant to hold the decoupled com_weblinks component and related code.
GNU General Public License v2.0
45 stars 88 forks source link

Weblinks : Weblinks not inheriting Global Settings for Target #397

Closed tapiochre101 closed 2 years ago

tapiochre101 commented 5 years ago

Steps to reproduce the issue

  1. In Components >> Web Links Manager >> Options, set Target to "Open in New Window"
  2. Create a new Weblink Category (or use an existing category)
  3. Create a new Weblink, assign to the category
  4. Set the Weblink's target is to "Use Global"
  5. Create a Weblink Module and assign the above category to the module. Assign module to a suitable menu and position.
  6. Visit front end and test the weblink.

Expected result

Weblink should open in a new tab or window.

Actual result

Weblink opens in Parent window

System information (as much as possible)

PHP Version | 7.2.14 Joomla! 3.9.3 Stable [ Amani ] 12-February-2019 15:00 GMT Web Links Extension Package version 3.6.0 (from Install from Web option of Installer)

Additional comments

  1. Setting weblink to use "Use Global" and inspecting the source of the link, there is no target="_blank" seen. In fact there is no 'target="....." at all.
  2. This missing 'target="..." us true no matter how the Global Setting for target us set.
  3. Setting the weblink's target to 'Open in new window' works.

Semi conclusion, is that the module is disregarding how the Global Target setting is set for weblinks.

Problem also seen in previous releases of J! 3.X

skuzmina commented 5 years ago

Hi,

Can you tell when it will get fixed in Joomla?

joomdonation commented 2 years ago

Hello

We fixed this issue for weblinks package for Joomla 4. If you still need it, please let us know and we will backport this change for the package for Joomla 3. For now, I'm closing this issue.