search

joomla-extensions / weblinks

This repo is meant to hold the decoupled com_weblinks component and related code.
GNU General Public License v2.0
45 stars 88 forks source link

Confirm about javascript in J4 branch #409

Closed wilsonge closed 4 years ago

wilsonge commented 5 years ago

@dgrammatiko can i confirm that the code I commented out in https://github.com/joomla-extensions/weblinks/commit/2be3dec52abbddf807cd9e1d83399327ec4911f9 is no longer required?

dgrammatiko commented 5 years ago

Yes, you’re right is not required as long as the form has a class form-validate which is the case in that page

wilsonge commented 5 years ago

Thanks!

richard67 commented 4 years ago

@wilsonge Can this be closed after last commit https://github.com/joomla-extensions/weblinks/commit/25fa454c985be7e024b68d18f9da8ad9f119ee6a to the 4.0-dev branch?

wilsonge commented 4 years ago

Code needs to be deleted rather than just commented out. After that yes

wilsonge commented 4 years ago

Oh i already did delete it and you linked to it 🤦‍♂