[4.0] Move de-DE to this repo

joomla-extensions / weblinks

This repo is meant to hold the decoupled com_weblinks component and related code.

GNU General Public License v2.0

45 stars 88 forks source link

[4.0] Move de-DE to this repo #415

Closed zero-24 closed 4 years ago

zero-24 commented 4 years ago

Pull Request for Issue https://github.com/joomlagerman/joomla/pull/805

Summary of Changes

As of Joomla 4.0 this file is not longer part of the core distribution so here the suggestion to keep the translation in this repo.

Testing Instructions

Install weblinks in 4.0 + de-DE installed

Expected result

GUI translated

Actual result

GUI not translated

Documentation Changes Required

none

zero-24 commented 4 years ago

@HLeithner @wilsonge any opinions here? else we can close here and just trash the translation.

HLeithner commented 4 years ago

We should have own language packages for these translation or shouldn't they be part of the german language pack?

infograf768 commented 4 years ago

Thoughts

Crowdin is not taking care of these when people use it to create core lang packs.
Looks like the module and plugins lang files are missing in this repo (if i do not mistake)
We have decided to include all fr-FR webkinks lang files in our general lang pack, but I have no idea about other TTs also doing so.
There is no process to install another language weblinks lang files from this repo in function of the site installed languages.
Starting to include them in the core of this repo could be considered as a solution, except if we advertise this and get many languages doing such. I doubt about it, but it could happen theoritically.

Conclusion: the separation of this component from core was done in amateur way... Was it really necessary? Should it had been kept still as a supported extension while no good solution was provided concerning languages ?

Sorry if this is considered as a rant.

HLeithner commented 4 years ago

So we should find a solution for this process, because it's possible that more components will be decoupled. May understanding was that the weblink decoupling was a test to learn how to it right... It seams there are improvements necessary to achieve this.

zero-24 commented 4 years ago

Any update on this topic? Is there anything against merging this into the repo and maybe remove it when there is a better solution?

infograf768 commented 4 years ago

Nothing new as far as I know.

wilsonge commented 4 years ago

Makes sense to me to setup up full crowdin integration here

HLeithner commented 4 years ago

based on downloads.joomla.org and the integration of j4 languages.

zero-24 commented 4 years ago

Makes sense to me to setup up full crowdin integration here

This would result into the current behavior that the TT's have to ship that with thier translation packages right? Why not ship it with the component like all other extensions handle translation, for sure an crowdin implementation could make sense but i would suggest to keep it out of the core translation packages and just ship it with the component.

infograf768 commented 4 years ago

Shipping ALL languages with the package (comp, mod, plugins) would be very heavy and independent on the installed languages.

zero-24 commented 4 years ago

Any progress made on that topic here or should that PR here just be closed? @infograf768 @HLeithner @wilsonge ?

zero-24 commented 4 years ago

Thanks :)