search

joomla-extensions / weblinks

This repo is meant to hold the decoupled com_weblinks component and related code.
GNU General Public License v2.0
45 stars 88 forks source link

Fix PHP warnings #434

Closed Harmageddon closed 3 years ago

Harmageddon commented 3 years ago

Similar to https://github.com/joomla/joomla-cms/pull/27273

Fixes #433.

Summary of Changes

This PR fixes PHP warnings for the weblinks category view.

Testing Instructions

  1. Create a category view.
  2. Add some weblinks
  3. Enable tags for this view.
  4. Look at the page in frontend.

Expected result

No PHP warnings

Actual result

Two times "Warning: Creating default object from empty value"

Documentation Changes Required

ChristineWk commented 3 years ago

I have tested this item :white_check_mark: successfully on 84ec6b93e7e327c590c0378ce9d16eb24116f8e4

changed to PHP 7.4.16 changed codes accordingly via FTP

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/weblinks/434.

joomdonation commented 3 years ago

Thanks @Harmageddon for your PR. I fixed the issue but we can improve the code abit to save the system from having to query tags data for weblink again. I made commit directly in your PR, hope that is OK

With patch applied, the issue is sorted and tags are being displayed as expected, so this PR works and I'm going to merge it.

category

Thanks

Harmageddon commented 3 years ago

Thank you!