Closed Sieger66 closed 2 years ago
Thanks @Sieger66 for your contribution. Actually, we have the code to show number of items already, see https://github.com/joomla-extensions/weblinks/blob/4.0-dev/src/components/com_weblinks/tmpl/category/default_children.php#L28 . But there is a typo in the name of the parameter, it should be show_cat_num_links instead of show_cat_items . Another copy/paste error :).
That could be fixed easily. However, @chmst : Do you remember why you are using float-end there? It should be displayed next to category title instead of floating to the end.
Also, in com_content https://github.com/joomla/joomla-cms/blob/4.0-dev/components/com_content/tmpl/category/default_children.php#L29-L56 , for some reasons, we have separate if else code for handling RTL. @chmst Could you please look at it to see if we need to apply the same change for weblinks?
This PR is not right, so I'm closing it. Thanks for helping @Sieger66
Pull Request for similar problem in category-view as for Issue #463
Summary of Changes
Add code to display number of links at weblinks-category-view to show_cat_num_links
Testing Instructions
Make weblinks-category and weblinks-subcategories with several of weblinks in it. Make a menu-item of type "List Web Links in a Category" (for category-view of com_weblinks) with set Show of # Web Links in the Category-Tab of the menu-item.
Expected result
See number of links in subcategories if set to show in menu-item
Actual result
See no number of links in subcategories