joomla-extensions / weblinks

This repo is meant to hold the decoupled com_weblinks component and related code.
GNU General Public License v2.0
45 stars 88 forks source link

[4.0] Fix adapting view categories to the core categories view #467

Closed chmst closed 2 years ago

chmst commented 2 years ago

Pull Request for Issue # .

Summary of Changes

Some changes were lost during lat commits. This PR adapts again the view categories of weblinks to categories of content.

Testing Instructions

Make a tree of categories for example grafik

Add description and image to categories as you like.

Add a menuitem of type categories to your menu

Expected result

grafik

joomdonation commented 2 years ago

I tried to test this but when I applied the change here, the expand icon is displayed in wrong position. See the attached screenshot for Content Categories and Weblinks Categories:

CT-Categories

WL-Categories

Also, I think we should use a different css class for com_weblinks instead of using com-content-categories__items . Could you please think about it and find a solution?

chmst commented 2 years ago

Could you please re-test?

Chenages are: The button is always in the first line, top right. So the following descriptopn and / or image have no influence grafik

joomdonation commented 2 years ago

So I tested it and it worked well. The reasons I have not merged this is because:

chmst commented 2 years ago

I suggest to merge this - it is better than now. We keep the classes with com-content as also com_contact uses them. They are used for categories views.

weblinks categories are slightly different form content categories, but should be displayed now correctly.

joomdonation commented 2 years ago

OK. I trust you for layout stuffs. Let's move on :) !