search

joomla-extensions / weblinks

This repo is meant to hold the decoupled com_weblinks component and related code.
GNU General Public License v2.0
45 stars 88 forks source link

[4.0] fix help buttons #468

Closed Bakual closed 2 years ago

Bakual commented 2 years ago

Pull Request for Issue https://github.com/joomla/joomla-cms/pull/35662#issuecomment-927308263

Summary of Changes

Removing JHELP language strings which were already not present in the INI files. Using hardcoded references like we do in core now. Adding information for help buttons in categories views and weblink edit form Removed one help button for the single weblink menuitem as there is currently no help page for that one.

Testing Instructions

Try the various help buttons,

Expected result

they should all work now.

Actual result

Some are missing, some are giving a 404 error

Documentation Changes Required

None

ChristineWk commented 2 years ago

Can't test it. Hv changed Github Repository of Joomla Patch Tester to:

patchtester-weblinks

(After checking & fetching) Got the list of previous issuing tracker, but not from Web Links.

Checked also: https://github.com/joomla-extensions/weblinks (Part of Patchtester Component)

Checking below, I get 404 RuntimeException

Invalid Issue

https://issues.joomla.org/tracker/weblinks/468

Bakual commented 2 years ago

I honestly don't know how you can test Weblinks.

joomdonation commented 2 years ago

Thanks ! Now I understand how help works :D.

Honestly, I don't know how to use patch tester to test weblinks, too, so I applied the changes manually to test it. Will try to play with patch tester later to see if it could be used to test weblinks PR.

Thanks @Bakual for the PR and thanks @ChristineWk for willing to help with testing.

Bakual commented 2 years ago

Thanks ! Now I understand how help works :D.

Honestly, I don't know how to use patch tester to test weblinks, too, so I applied the changes manually to test it. Will try to play with patch tester later to see if it could be used to test weblinks PR.

Thanks @Bakual for the PR and thanks @ChristineWk for willing to help with testing.

There is a third variant for help screens where the extension installs the help files directly with the extension. I don't understand yet how that works, probably broken anyway 😀