Closed chmst closed 2 years ago
@chmst I think we should not introduce new parameter to module like this. We should use Target parameter from component configuration instead
So some kind of merging weblinks item parameters with component parameters (same as how we do in category view)
Hmm. Looking at the module, I can now see that we have Count Clicks parameter. From what I see, the value from that parameter is not used at all (because count click is set for every item, so it never inherit from module parameter or component parameter)
It would make sense if inside Count Clicks parameter in weblink add/edit form we have an option (Use Global) instead of a switcher with Yes/No at the moment
How do you think about this?
Pull Request for Issue #424 #397 .
Summary of Changes
Parameter target added![image](https://user-images.githubusercontent.com/1035262/138604091-f8151154-9df7-40c0-9a18-7f88604b9148.png)
Testing Instructions
Apply the patch, make a weblinks module and set the target in different modes. Make sure that the weblinks are opened as defined.
Expected result
Weblinks open as defined by params
Actual result
There is no param for setting the value
Documentation Changes Required
?