search

joomla-extensions / weblinks

This repo is meant to hold the decoupled com_weblinks component and related code.
GNU General Public License v2.0
45 stars 88 forks source link

Improve weblinks parameter handling in weblinks module #474

Closed joomdonation closed 2 years ago

joomdonation commented 2 years ago

Pull Request for Issue # .

Summary of Changes

This PR improve how Count Clicks and Target parameters are handled in weblinks module:

  1. Add Use Global to Count Clicks field on add/edit weblinks form. Without this option, the Count Clicks parameter parameter in component setting and in the module is useless.
  2. Remove Count Clicks parameter form weblinks module. We will now handle count clicks by merging parameters from weblink item with component parameters, same as how we handle it inside the component. The module should work in the same way with component and should not need a new parameter
  3. Target for link is now handled properly

@chmst Could you take a look at this PR?