search

joomla-extensions / weblinks

This repo is meant to hold the decoupled com_weblinks component and related code.
GNU General Public License v2.0
45 stars 88 forks source link

[4.0] Fix Drone Build issue #490 #491

Closed alexandreelise closed 2 years ago

alexandreelise commented 2 years ago

Fix #490 for joomla-extensions/weblinks 4.0-dev branch

Pull Request for Issue #490 .

Summary of Changes

Edit branch name from staging to 4.0-dev in RoboFile.dist.ini

Testing Instructions

Do a pull request on 4.0-dev branch of joomla-extensions/weblinks repo.

Expected result

Build continues the steps after cloning joomla/jooma-cms repo

Actual result

Build fails when trying to clone the non existing staging branch of joomla/joomla-cms repo

Documentation Changes Required

Maybe.

alexandreelise commented 2 years ago

Now the build continues build fails for another reason. Seems to be related to a deprecated _bootstrap.php config which from the logs should be bootstrap.php without the underscore.

Hackwar commented 2 years ago

Thank you for your work. As with your other PR, @richard67 had already made a more complete PR to fix this, which I just merged. I'm going to close this PR for now.

alexandreelise commented 2 years ago

Ok Thanks @Hackwar @richard67