Update postsavehook params

joomla-extensions / weblinks

This repo is meant to hold the decoupled com_weblinks component and related code.

GNU General Public License v2.0

45 stars 88 forks source link

Update postsavehook params #497

Closed chmst closed 2 years ago

chmst commented 2 years ago

Pull Request for Issue # .

Summary of Changes

Replace JModelLegacy by BaseDatabaseModel in postsavehook

Testing Instructions

Expected result

Actual result

Documentation Changes Required

joomdonation commented 2 years ago

Looks good, so I'm merging. I wonder why we ever need that postSaveHook method at all, look like it could be removed. But we will do that in a different PR when I have more time to look at it more carefully.

chmst commented 2 years ago

I think that it is not used anywhere - but wold not remove as long as I am not sure about. Thanks for merging.

joomdonation commented 2 years ago

It is called after the weblink item saved. However, that code is useless because without the method, users will still being redirected to weblinks management screen after pressing Save And Close button.