WebClient.php. PHP 8.0. Undefined array key when user agent "Chrome Privacy Preserving Prefetch Proxy" - Githubissues

joomla-framework / application

Joomla Framework Application Package

GNU General Public License v2.0

22 stars 30 forks source link

WebClient.php. PHP 8.0. Undefined array key when user agent "Chrome Privacy Preserving Prefetch Proxy" #112

Open ReLater opened 1 year ago

ReLater commented 1 year ago

Steps to reproduce the issue

See https://github.com/joomla/joomla-cms/issues/39637

Expected result

User agent "Chrome Privacy Preserving Prefetch Proxy" is ignored by elseif(). https://github.com/joomla-framework/application/blob/2.0.2/src/Web/WebClient.php#L436
No PHP warning.

Actual result

Undefined array key 1 in libraries/vendor/joomla/application/src/Web/WebClient.php on line 439

Additional comments

Maybe(?): https://github.com/joomla/joomla-cms/issues/39637#issuecomment-1383241989

richard67 commented 1 week ago

It seems we have in general an issue when certain user agents are specified without a (numeric) version number. See also this CMS issue: https://github.com/joomla/joomla-cms/issues/44469 .

Unfortunately I think it is not fixed by the already merged PR #131 .

richard67 commented 1 week ago

Please test #132 . Thanks in advance.