search

joomla-framework / application

Joomla Framework Application Package
GNU General Public License v2.0
22 stars 30 forks source link

fix for php 8.2 #43334 #124

Closed alikon closed 3 months ago

alikon commented 7 months ago

Pull Request for Issue #43333

Summary of Changes

Testing Instructions

Documentation Changes Required

carlovthunder commented 6 months ago

I use Joomla 4.4.4 and Php 8.3 I have correct from: $this->userAgent = $this->userAgent ?? ''; to $this->userAgent = $userAgent;

The Joomla https://address/admin is malformed, it work only on http://address/admin

rdeutz commented 3 months ago

if my changed in https://github.com/joomla-framework/application/pull/126 will be implemented then this here is not needed. Further more setting it to am empty string doesn't make a difference to null, as far as I can see. Closing this one that for makeing the PR

tallandtrue commented 2 weeks ago

Just to add this error has cropped up for me as well on my Joomla 5.1.4 website running PHP 8.1:

PHP Deprecated: stripos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /home/[root-folder]/[website-folder]/libraries/vendor/joomla/application/src/Web/WebClient.php

Although these are only warnings, the negative impact is that my Joomla error_log grew, which I only realised when I received disk space warnings.

For now, I've followed the advice in another post and have turned off error logging in Joomla.