stripos null user agent warning

joomla-framework / application

Joomla Framework Application Package

GNU General Public License v2.0

21 stars 29 forks source link

Open wussup opened 2 months ago

wussup commented 2 months ago

stripos can not take a null value as an argument in PHP 8.1+

Deprecated: strpos(): Passing null to parameter #1 ($haystack)

check $userAgent before use stripos() function

make GET request without User Agent header

nothing

rdeutz commented 1 month ago

Thanks for the PR.

Sorry for the delay in replying:

Please fix the code style issues
It would be better to make an early return when the $userAgent is empty, moving "$this->detection['engine'] = true;" to the top of the functions is fine
Please make the change for all detect functions.

Quy commented 3 days ago

Alternative PR #131