Restructure application class tests

joomla-framework / application

Joomla Framework Application Package

GNU General Public License v2.0

21 stars 29 forks source link

Restructure application class tests #45

Closed mbabker closed 9 years ago

mbabker commented 9 years ago

Restructure's AbstractApplicationTest, AbstractCliApplicationTest, and AbstractWebApplicationTest to use the PHPUnit API for mocking objects (concrete and abstract) and our own API for injecting objects versus using our Reflection based TestHelper to manipulate the class variables. Also uses PHPUnit's assertions to test the objects as appropriate and deal with instances where we need to adjust values in superglobals.

wilsonge commented 9 years ago

This looks good to me

mbabker commented 9 years ago

@wilsonge Merge if you're good with this. After your changes in #47 there's nothing left in the web test case that's actually altering $_SERVER now; everything is fully mocked and injected.