search

joomla-framework / application

Joomla Framework Application Package
GNU General Public License v2.0
21 stars 29 forks source link

Container support in Applications #50

Closed laoneo closed 9 years ago

laoneo commented 9 years ago

Moving attributes of the applications to a DI container. Additionally some helper function have been introduced for easy access to the variables.

This PR solves a requirement of Joomla 4, to deliver a container in the application which serves as the root container for the component execution process. The PR for Joomla 4 can be found here https://github.com/joomla-projects/joomla-pythagoras/pull/26

laoneo commented 9 years ago

Ok. Did understand something wrong.

laoneo commented 9 years ago

I reverted the code and made the base application container aware. Guess that's all we need at this stage.

mbabker commented 9 years ago

Let's do it this way: Open a PR against the 2.0-dev branch using your https://github.com/Digital-Peak/application/commit/a7643ac7e45fc638971d71e931c44adab5abf167 commit and bump the minimum to PHP 5.4. Let's also require joomla/di 2.0.*@dev too since that branch has the revised DI container that Niels worked on. This will let us move forward with the updated code.

laoneo commented 9 years ago

New PR #51.