search

joomla-framework / database

Joomla Framework Database Package
GNU General Public License v2.0
28 stars 35 forks source link

CI configuration unexpectedly leaks into testing environment #222

Closed mbabker closed 3 years ago

mbabker commented 3 years ago

Commits such as https://github.com/joomla-framework/database/commit/073aff4cde74bdd8f2db65c520610239d0a9ed43 have leaked environment variables used to configure the various CI platforms into the test suite. This essentially changes the testing workflow so that it will only run correctly on a properly configured CI platform, different from the user expectation that the tests should be executable in any environment with the correct settings.

If it is intended to require this type of configuration when executing the tests, these requirements should follow existing conventions for defining constants or env vars and clearly documented for all contributors to use. Otherwise, not documenting this mandatory change will result in unexpected behaviors if the tests are run outside of the configured CI environment.

nibra commented 3 years ago

Thank you @mbabker for pointing this out. I was too focused on getting the build to work at all, so I completely overlooked this aspect.