search

joomla-framework / database

Joomla Framework Database Package
GNU General Public License v2.0
28 stars 34 forks source link

Adding missing abstract getColumnSQL method to importer #268

Closed Hackwar closed 1 year ago

Hackwar commented 2 years ago

phpstan complains that we are accessing this method in the DatabaseImporter class, but it isn't defined, not even as abstract class. All importer classes have this method declared, so this is just a method of adding this after the fact. The question is, if this is acceptable from a semver point of view. An importer wouldn't be working without having this method implemented...

Hackwar commented 1 year ago

We are going to fix this in 3.x. Probably.