search

joomla-framework / database

Joomla Framework Database Package
GNU General Public License v2.0
28 stars 35 forks source link

Several fixes from phpstan #283

Closed Hackwar closed 10 months ago

Hackwar commented 1 year ago

Summary of Changes

This PR has several changes from reports from phpstan.

  1. The exception, which we are trying to catch, isn't thrown in the code. Instead an UnknownArchiveException is used and should thus be properly caught.
  2. Several docblocks have been fixed.
  3. DatabaseImporter got a signature for getColumnSQL()
  4. DatabaseInterface got a signature for getPrefix()
  5. QueryInterface got a signature for quoteName()
wilsonge commented 10 months ago

The Interface modifications are b/c breaks which need documentation