joomla-framework / database

Joomla Framework Database Package
GNU General Public License v2.0
28 stars 35 forks source link

FIX With Mariadb 11.1.2 ordering of table is broken #290 #291

Open tkuschel opened 8 months ago

tkuschel commented 8 months ago

Pull Request for Issue #290 also see https://issues.joomla.org/tracker/joomla-cms/42333

Summary of Changes

Removed public function selectRowNumber($orderBy, $orderColumnAlias) in MysqlQueryBuilder.php it already works within DatabaseQuery.php with window function ROW_NUMBER()

Testing Instructions

see https://issues.joomla.org/tracker/joomla-cms/42333

Documentation Changes Required

only valid for Joomla 5.x because MariaDB and MySQL miniumum

tkuschel commented 8 months ago

Please be kind and add a test with the Mariadb 11.1.x version, see https://mariadb.com/kb/en/mariadb-11-1-3-release-notes/

PhilETaylor commented 4 months ago

This issue DOES effect Joomla 3 sites running on 11.2.2-MariaDB also.

The fix to remove the function selectRowNumber in the Joomla 3 file libraries/joomla/database/query/mysqli.php just like this PR proposes for Joomla 5

nielsnuebel commented 4 months ago

I have tested this successfully. We need this in the next Joomla Version asap.

tecpromotion commented 4 months ago

I have tested this successfully. We need this in the next Joomla Version asap.

HLeithner commented 4 months ago

We can't do this change because it would break the supported mysql versions for 3.x branch.

Can you please add a version check to only use the "parent" implementation when mariadb >= 11.0 is used?

tkuschel commented 4 months ago

Can you please add a version check to only use the "parent" implementation when mariadb >= 11.0 is used?

I'm currently on rehabilitation and can't work on it from here. Perhaps someone else can take over. I'll be away for at least 6 weeks.

richard67 commented 4 months ago

I'm currently on rehabilitation and can't work on it from here. Perhaps someone else can take over. I'll be away for at least 6 weeks.

@tkuschel My best wishes for you. I hope all will go well. Maybe @HLeithner or me can take over.

richard67 commented 4 months ago

Regarding the versions check see my alternative PR #300 .