search

joomla-framework / datetime

Joomla Framework DateTime Package
GNU Lesser General Public License v2.1
3 stars 2 forks source link

The methods called before() and after() should probably be renamed to be more explanatory #2

Closed aDaneInSpain closed 10 years ago

aDaneInSpain commented 10 years ago

What do they do? I will help you name them better if you like.

tomaszhanc commented 10 years ago

They check if the object is before or after another one. Maybe the better names would be: isBefore() and isAfter()?

aDaneInSpain commented 10 years ago

Object? You mean a date?

So $date->isAfter('2007-12-23')

If so, then yeah adding the "is" keyword would help.