Closed mbabker closed 10 years ago
Just to preface this, I haven't touched pretty much any of the code functionality. Overall, it looks great.
This PR is my review over the package to get it up to standard. It's mostly dealing with repo structure and documentation. Just to try and summarize:
composer.lock
.gitignore
composer.json
Joomla\DateTime\Test
Date
DateTime
Just to preface this, I haven't touched pretty much any of the code functionality. Overall, it looks great.
This PR is my review over the package to get it up to standard. It's mostly dealing with repo structure and documentation. Just to try and summarize:
composer.lock
to the.gitignore
, the same as the rest of the Framework packagescomposer.json
file and restructured it a bit to load in testing dependencies only in the development environmentJoomla\DateTime\Test
namespaceDate
andDateTime
classes.